Repository navigation
Conversation
d5f1309 to
bbd194a
Compare
|
Quick progress update on #992:
I've opened #994 to track the underlying plugin resource-resolution limitation separately, without expanding the scope of this PR. I'll keep #992 in Draft until the remaining work is addressed. |
|
The implementation is ready for maintainer review. The shared rule publisher is now integrated (#979 is no longer blocking), and CI is green, including Kilo 7.7.5 Linux E2E, Windows CLI, mutation tests, and CodeQL. I'd appreciate your feedback on three points:
Beyond Kilo-native generation, this PR includes:
The first changes support Kilo integration and existing host compatibility. The "skill-eval" extensions are less directly related. Would you prefer to keep everything together or extract the independent changes into a follow-up PR?
AC16 requires an official source and the September 25, 2026 verification date for every Kilo path claim. I centralized the references in "official-sources.md" (https://github.com/ai-driven-dev/framework/blob/ccd32e3bd9075cce43be6bea4a7bb1c60a14e6dd/aidd_docs/tasks/2026_10/2026_10_10_kilo-native-generation-914/official-sources.md), recording the actual October 13 re-verification rather than claiming independent evidence for September 25. Does this centralized approach satisfy AC16's intent?
"CONTRIBUTING.md" requires testing with Claude and another tool. I don't have a Claude subscription or budget for paid API usage. However, an authenticated Codex CLI 0.162.1 run successfully generated a native Kilo skill using AIDD, and a subsequent Kilo 7.8.8 Linux runtime test verified discovery, loading, and payload consumption. This is a scoped validation, not a full "skill-eval" suite pass. Would you accept this Codex/Kilo evidence as an exception to the Claude requirement, or could a maintainer perform the Claude validation? Follow-up issues Three follow-up issues are tracked separately:
None of these issues is claimed as resolved here. Other validation limitations are documented in the PR description. Thanks for your guidance before merging! |
Cover six canonical and legacy signals without false Kilo detection from shared AGENTS or OpenCode config. Keep OpenCode detection unchanged. TASK 1 of ai-driven-dev#914 phase 1. Detection contracts: 24/24 pass; removing the nested JSONC signal causes a targeted failure.
Reuse the shared AGENTS destination and preflight all selected files before Upsert and Fill. Preserve user bytes and keep automatic hooks best-effort. Reject known unsafe destinations before any selected write. TASK 2 of ai-driven-dev#914 phase 1. 40 memory tests and 24 detection tests pass. Final make check: 604 pass, 2 existing skips, 0 fail. Real Kilo reads linked memory and applies its instruction at reported cost zero.
Record TASK 3 runtime proof, review, assertions, task statuses and resumption decisions for ai-driven-dev#914 phase 1. Preserve the approved plan and its previous snapshot; later phases remain pending and require separate authorization. Native Codex generated shared memory. Real Kilo read the linked file and applied its instruction at reported cost zero. Final checks: 64 targeted pass; 604 full-script pass, 2 existing skips; review approve. Claude authenticated runtime and standalone Codex CLI limitations remain explicit.
Require an explicit portable choice and resolve shared target conflicts before publication. Preserve host field contracts and user resources with a full preflight, and record actual caller generation and Kilo runtime evidence. Scope is limited to validated phase 3. The overall plan remains in progress; Claude authentication, other Kilo platforms and subsequent phases remain open. Refs ai-driven-dev#914
Implement phase 4 of ai-driven-dev#914 with Kilo contracts, regression coverage, and Linux runtime proof.
docs: archive phase 5 validation reruns Record targeted Persona and pinned Kilo runtime evidence for ai-driven-dev#914. test(aidd-context): prove hook contract assertions Exercise seven targeted source-contract mutations for ai-driven-dev#914 and tighten the two assertions that survived initial probes. Archive final phase-5 validation and update the coverage matrix and review.
Verify project-file descriptors while preserving user content and metadata, and refuse detected substitutions and hard-linked targets. Use private test fixtures and descriptor-backed witnesses. Make line-ending, permission, mode, and parent-identity expectations explicit across platforms. Refs ai-driven-dev#914
Extend the canonical rule publication flow for Kilo while preserving project configuration and existing host behavior. Refs ai-driven-dev#914
Document merged Kilo instructions and cover coexistence in the real 7.7.5 runtime. Refs ai-driven-dev#914
Keep the plugin overview focused on shared behavior and avoid repeating the Kilo config-selection contract. Remove private runtime identifiers from retained task evidence. Refs ai-driven-dev#914
Document standalone detection and official Kilo sources. Add rerun and collision checks to support ai-driven-dev#914 acceptance review.
c0f51a1 to
5f2fcb0
Compare
Exercise ambiguous configuration selection and predictable publication failures without claiming crash recovery or concurrent atomicity. Refs ai-driven-dev#914
|
Progress update PR #992 has been rebased onto Changes completed:
Validation: All applicable CI checks pass on the latest PR HEAD, including the targeted Kilo validations. The following maintainer decisions remain open:
The remaining acceptance-criteria gaps and follow-up issues are documented in the PR description. Thanks for reviewing! |
🎯 What & why
Adds native Kilo support to
aidd-context, enabling Kilo projects to onboard AIDD and generate discoverable project memory, rules, skills, agents, and workflows while preserving compatibility with other supported tools.🛠️ How it works
.kilo/, rootkilo.json/kilo.jsonc,.kilo/kilo.json/.kilo/kilo.jsonc, and legacy.kilocode/. NeitherAGENTS.mdalone nor OpenCode-only configuration triggers Kilo detection. SharedAGENTS.mdproject memory preserves user-owned content..kilo/rules/<category>/<slug>.mdfiles and registers their exact paths in Kiloinstructions. Legacy.kilocode/projects write new rules only to canonical.kilo/paths. Unsupported path-scoped rules are rejected before any mutation rather than silently converted to non-enforceable prose..kilo/skills/generation and explicitly selected portable.agents/skills/placement..kilo/agents/and.kilo/commands/.skill-evalwith Claude/Codex support, JSON checks, project-tree snapshots, and explicitPASS/FAIL/INCOMPLETEreporting. Invalid--jobsand--repeatvalues are rejected before workers or evaluations start.The rule-generation guidance keeps its detection contract within the skill, preserving standalone installation compatibility.
Implementation details and host contracts are documented in the [aidd-context README](https://github.com/ai-driven-dev/framework/blob/3c5d574545da673a61110d435bf42ec1892aab40/plugins/aidd-context/README.md).
🧪 How to verify
Run the focused Kilo CLI tests:
cd cli pnpm test:e2e:kilo pnpm test:e2e:kilo:nativeValidation evidence:
3c5d574; conditional release jobs were skipped.skill-evalexecution counts and standalone skill-link boundaries.These are scoped behavioral and runtime validations, not a claim that the full
skill-eval --host=codexsuite passed.The AC references below correspond to the acceptance criteria defined in #914.
Maintainer decisions requested
1. PR scope — cross-tool changes
Besides native Kilo generation, this PR includes shared project-memory and rule-publishing hardening, hook compatibility improvements, and
skill-evalextensions.Should these changes remain together in #992, or should some independent improvements be extracted into follow-up PRs?
2. AC16 — Official documentation traceability
Official Kilo paths, formats, sources, and verification provenance are centralized in [official-sources.md](https://github.com/ai-driven-dev/framework/blob/3c5d574545da673a61110d435bf42ec1892aab40/aidd_docs/tasks/2026_10/2026_10_10_kilo-native-generation-914/official-sources.md).
Issue #914 records September 25, 2026, as the requested verification date; the documentation was independently rechecked on October 13, 2026.
Does this centralized evidence satisfy AC16, or is per-claim traceability required?
3. Authenticated Claude validation
CONTRIBUTING.mdrequests testing with Claude and another tool. Authenticated Codex generation and Kilo runtime validations are available, but no authenticated Claude Code generation session has been performed.Can the available Codex/Kilo evidence be accepted, or could a maintainer perform the missing Claude validation?
Remaining acceptance-criteria coverage
The following acceptance criteria from #914 remain partially demonstrated. These gaps remain tracked under the original issue unless explicitly associated with a separate follow-up below.
Maintainer guidance on whether additional evidence is required before merging would be appreciated.
AC1–4 — Detection: The six Kilo signals, negative OpenCode/
AGENTS.mdcases, and legacy rule publication have targeted coverage. Complete behavioral validation across every applicable generator is not established.AC7 — Configuration precedence: JSON/JSONC candidates, ownership, explicit selection, and ambiguity handling are tested. Complete Kilo runtime precedence is not established.
AC13 — Idempotence: Deterministic publication paths have replay tests. Idempotence of an entire LLM conversation is not guaranteed. No separate issue has been created for this broader interpretation of the acceptance criterion.
AC14 — Write safety: Preflight, refusal paths, hardlinks, and best-effort rollback are tested. The separate project-memory corruption defect involving I/O write failures is tracked in [#1018](fix(aidd-context): preserve project-memory files on write failure #1018). This PR does not claim to resolve that issue or guarantee crash recovery, concurrent-mutation safety, or atomic multi-file updates.
AC15 — Runtime coverage: Kilo runtime validation remains Linux-based. Native Kilo runtime validation on macOS and Windows is outstanding.
AC16 and authenticated Claude validation are addressed in the maintainer decisions above.
The remaining gaps do not necessarily indicate confirmed implementation defects. Some concern the scope of required guarantees or the completeness of the available evidence.
Related PR and independent follow-ups
Related integration:
Independent follow-up issues:
.aidd/cachecontent causes unrelated Markdown link-validation failures.These issues are tracked independently. This PR does not claim to resolve them, and their existence does not automatically mean that every corresponding acceptance-criteria gap requires a separate implementation.
Maintainer review and the outstanding decisions remain necessary before merging.
🔗 Linked issue
Refs #914
✅ I certify